Update dapp workflows to handle deps version discrepancies #4433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
force-pushed
the
mhofman/fix-dapp-ci
branch
from
17229ca to
4827d9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #4384 and #4427 landed,
dapp-fungible-faucetbroke because parcel v1 is buggy (see parcel-bundler/parcel#2946). However this was not caught by CI because the dapps were checked out as a subfolder ofagoric-sdk. This PR changes the dapp workflows to isolate thedappandagoric-sdkcheckout locations.Extracted from #4420 as we realized this problem exists independent of the TypeScript change.
Security Considerations
N/A
Documentation Considerations
N/A
Testing Considerations
Requires Agoric/dapp-fungible-faucet#39